Re: pg_settings.unit and DefineCustomXXXVariable - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_settings.unit and DefineCustomXXXVariable
Date
Msg-id 1653023.1736349505@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_settings.unit and DefineCustomXXXVariable  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Responses Re: pg_settings.unit and DefineCustomXXXVariable
List pgsql-hackers
Matthias van de Meent <boekewurm+postgres@gmail.com> writes:
> On Wed, 8 Jan 2025 at 11:13, Luca Ferrari <fluca1978@gmail.com> wrote:
>> I need to define a few GUCs, and for that purpose I'm using
>> DefineCustomXXXVariable functions that provide hooks for assignment,
>> show and check. However it is not clear to me if it is possible to
>> populate the unit column in pg_settings for the custom defined
>> variables, and if so, how.

> DefineCustomXXXVariable has a 'flags' argument, into which GUC_UNIT_*
> can be or-ed.

Correct.  contrib/auto_explain has some examples.

> AFAIK, the options provided in guc.h are the only kinds of units
> supported and available, and I think only integer variables actually
> support the unit conversion implied by the unit options.

Nowadays we allow units for float GUCs as well.  (Originally it was
indeed just for integers.  But at some point we decided an existing
integer value with units needed to become float, and then we had
to back-fill the implementation for compatibility's sake.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Reorder shutdown sequence, to flush pgstats later
Next
From: Fujii Masao
Date:
Subject: Re: ecpg command does not warn COPY ... FROM STDIN;