Re: Optimize Arm64 crc32c implementation in Postgresql - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Optimize Arm64 crc32c implementation in Postgresql
Date
Msg-id 1644.1525322909@sss.pgh.pa.us
Whole thread Raw
In response to Re: Optimize Arm64 crc32c implementation in Postgresql  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: Optimize Arm64 crc32c implementation in Postgresql
List pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Thu, May 3, 2018 at 4:04 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> It strikes me also that, at least for debugging purposes, it's seriously
>> awful that you can't tell from outside what result this function got.

> I don't think *broken* CPUs are something we need to handle, are they?

I'm not worried so much about broken hardware as about scenarios like
"Munro got the magic constant wrong and nobody ever noticed", or more
likely "somebody broke it later and we didn't notice".  We absolutely
do not expect the code path with function-returns-the-wrong-answer to be
taken, and I think it would be appropriate to complain loudly if it is.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Optimize Arm64 crc32c implementation in Postgresql
Next
From: Thomas Munro
Date:
Subject: Re: Optimize Arm64 crc32c implementation in Postgresql