Re: [PATCH] Tiny optmization. - Mailing list pgsql-hackers

Ranier Vilela <ranier_gyn@hotmail.com> writes:
> Redudant because he it's been dereferenced here:
> line 3410:
>         cstate = BeginCopy(pstate, true, rel, NULL, InvalidOid, attnamelist, options);

Not necessarily ... the rel!=NULL code path there doesn't touch pstate,
and that seems to be what contrib/file_fdw is relying on.

Arguably, the rel==NULL code path in BeginCopy should be prepared to
support pstate being null, too.  But what you proposed here is certainly
not OK.

            regards, tom lane