Hi,
I know very well, so all texts in my patches should be translated to
English. My language skills are really minimal.
So, please, if you can, propose these error messages (with hints)-
result will be much better.
Thank you
Pavel
2009/4/10 Brendan Jurd <direvus@gmail.com>:
> On Sat, Apr 11, 2009 at 2:16 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>>
>> I was surprised so PostgreSQL doesn't support this basic output format.
>>
>
> Hi Pavel,
>
> I had a look through your patch and would like to suggest improvements
> to the new error messages you've introduced.
>
> 1. "invalid using of format EEEE"
>
> This message occurs several times in the patch. For one thing, the
> grammar is wrong; it should be "use", not "using".
>
> Additionally, this message on its own is not very helpful. If I was
> trying to use to_char and got "invalid use of format" my first thought
> would be "Invalid how?" The message should at minimum have a DETAIL,
> and possibly a HINT as well to make it effective.
>
> 2. "cannot use EEEE and others"
>
> The wording on this message is a bit awkward. I think what you meant
> to say is that EEEE cannot be used with certain other formatting
> codes, but this should be made explicit in the message.
>
> Cheers,
> BJ
>
