Re: Window-functions patch handling of aggregates - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Window-functions patch handling of aggregates
Date
Msg-id 162867790812250502j94a1258g5a2baa0ba5566767@mail.gmail.com
Whole thread Raw
In response to Re: Window-functions patch handling of aggregates  ("Hitoshi Harada" <umi.tanuki@gmail.com>)
Responses Re: Window-functions patch handling of aggregates
List pgsql-hackers
2008/12/25 Hitoshi Harada <umi.tanuki@gmail.com>:
> 2008/12/25 Greg Stark <greg.stark@enterprisedb.com>:
>> Yeah, it seems like adding a flag like iswindowable to aggregate functions
>> is the safest option.
>>
>> It would be nice if it represented an abstract property of the state
>> function or final function rather than just "works with the implementation
>> of window functions". I'm not sure what that property is though -
>> isidempotent? isreentrant? Maybe just  a vague isrepeatable?
>
> No, I meant wrinting such like:
>
> Datum
> some_trans_fn(PG_FUNCTION_ARGS)
> {
>  if (fcinfo->context && IsA(fcinfo->context, WindowAggState))
>    elog(ERROR, "some_agg does not support window aggregate");
>
> ...
> }
>
> rather than adding column to catalog. To add flag you must add new
> syntax for CREATE AGGREGATE, which is slightly more painful.
>

enhancing of CREATE AGGREGATE syntax should be better, it could solve
problem with compatibility.

regards
Pavel Stehule

> Regards,
>
> --
> Hitoshi Harada
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Updates of SE-PostgreSQL 8.4devel patches (r1348)
Next
From: "Hitoshi Harada"
Date:
Subject: Re: Window-functions patch handling of aggregates