Re: Crash on promotion when recovery.conf is renamed - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Crash on promotion when recovery.conf is renamed
Date
Msg-id 16230.1490622488@sss.pgh.pa.us
Whole thread Raw
In response to Re: Crash on promotion when recovery.conf is renamed  ("Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>)
List pgsql-hackers
"Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com> writes:
> All other places in twophase.c and most places in other files put ereport() and errmsg() on separate lines.  I think
itwould be better to align with surrounding code. 

> +                ereport(FATAL, (errmsg("corrupted two-phase file \"%s\"",

Actually, the *real* problem with that coding is it lacks a SQLSTATE
(errcode call).  The only places where it's acceptable to leave that
out are for internal "can't happen" cases, which this surely isn't.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: Page Scan Mode in Hash Index
Next
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Subject: Re: perlcritic