Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c) - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)
Date
Msg-id 161BDA33-F64B-44B0-8B29-3D17BC888786@yesql.se
Whole thread Raw
In response to Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)
List pgsql-hackers
> On 4 Sep 2024, at 19:30, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> On Wed, Sep 04, 2024 at 02:10:28PM -0300, Ranier Vilela wrote:
>> I think that commit 6ebeeae
>> <http://6ebeeae29626e742bbe16db3fa6fccf1186c0dfb> left out an oversight.
>> 
>> The report is:
>> CID 1559991: (#1 of 1): Dereference null return value (NULL_RETURNS)
>> 
>> The function *findTypeByOid* can return NULL.
>> It is necessary to check the function's return,
>> as is already done in other parts of the source.
>> 
>> patch attached.
> 
> Yeah, that looks like a problem to me.  I've cc'd Daniel here.

Thanks for the report, it does seem genuine to me too.  I'll get that handled
later today.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: gamma() and lgamma() functions
Next
From: Noah Misch
Date:
Subject: Re: Use read streams in pg_visibility