Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall - Mailing list pgsql-hackers

From Cary Huang
Subject Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall
Date
Msg-id 161704074015.1180.15614499301846689907.pgcf@coridan.postgresql.org
Whole thread Raw
Responses Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
Tree view 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Hi

I have tried the patch and the new option is able to control the contents of pg_dump outputs to include only create db
relatedcommands. I also agree that the option name is a little misleading to the user so I would suggest instead of
using"create-only", you can say something maybe like "createdb-only" because this option only applies to CREATE
DATABASErelated commands, not CREATE TABLE or other objects. In the help menu, you can then elaborate more that this
option"dump only the commands related to create database like ALTER, GRANT..etc"
 

Cary Huang
-------------
HighGo Software Inc. (Canada)
cary.huang@highgo.ca
www.highgo.ca

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Idea: Avoid JOINs by using path expressions to follow FKs
Next
From: Justin Pryzby
Date:
Subject: Re: Merging statistics from children instead of re-sampling everything