Re: Log query parameters for terminated execute - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: Log query parameters for terminated execute
Date
Msg-id 16162831532340351@sas1-640e2cc17194.qloud-c.yandex.net
Whole thread Raw
In response to Re: Log query parameters for terminated execute  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
Responses Re: Log query parameters for terminated execute  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
List pgsql-hackers
Hello
Thank you for review!
Well, i can miss some cases. I'm not sure about overall design of this patch. Is acceptable add errdetail_params to
statement_timeoutereport in such way?
 

After shutdown signal we must be in aborted state, so we mustn't call user-defined I/O functions. (quotation from
commentto errdetail_params in src/backend/tcop/postgres.c ). It seems i can not fix it with current design.
 

> ERROR:  canceling statement due to lock timeout at character 13
Hm, "at character"? How can we get this message? I found only "canceling statement due to lock timeout" (without "at
character")ereport in src/backend/tcop/postgres.c
 
Maybe try .. catch in parse state, not in execute?

regards, Sergei


pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw withpartition wise join enabled.
Next
From: Thomas Munro
Date:
Subject: Re: Possible performance regression in version 10.1 with pgbenchread-write tests.