Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted - Mailing list pgsql-hackers

From Neil Chen
Subject Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted
Date
Msg-id 160577401827.18283.12544488614854285060.pgcf@coridan.postgresql.org
Whole thread Raw
Responses Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted  (Pavel Borisov <pashkin.elfe@gmail.com>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hi, I have tested the feature and it worked well. 
One thing that doesn't matter is that the modify here seems unnecessary, right?

> mdunlinkfork(RelFileNodeBackend rnode, ForkNumber forkNum, bool isRedo)
> {
> char       *path;
> -    int            ret;
> +    int            ret = 0;
> path = relpath(rnode, forkNum

pgsql-hackers by date:

Previous
From: Masahiro Ikeda
Date:
Subject: Re: Add statistics to pg_stat_wal view for wal related parameter tuning
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: Terminate the idle sessions