Jorgen Austvik <Jorgen.Austvik@Sun.COM> writes:
> Tom Lane wrote:
>> Actually, it looks to me like the patch is wrong specifically because
>> it does not do the right thing in the VPATH case.
> Are you thinking about "failing if the folders are missing" as "not the
> right thing in the VPATH case", or are you thinking about something else?
The point is that in VPATH you are running in a build tree, and should
copy the source files from the source tree, but *not* modify the source
tree. Thus, fetching relative to $srcdir but writing relative to .
is in fact the correct behavior.
There has not previously been any complaint that pg_regress was broken
in this regard, so maybe you should take two steps back and explain what
problem you think needs fixing, rather than just dropping a patch on us.
regards, tom lane
