Re: Support TZ format code in to_timestamp() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Support TZ format code in to_timestamp()
Date
Msg-id 160136.1706112793@sss.pgh.pa.us
Whole thread Raw
In response to Re: Support TZ format code in to_timestamp()  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Aleksander Alekseev <aleksander@timescale.com> writes:
> +SELECT to_timestamp('2011-12-18 11:38 JUNK', 'YYYY-MM-DD HH12:MI TZ');  -- error
> +ERROR:  invalid value "JUNK" for "TZ"
> +DETAIL:  Time zone abbreviation is not recognized.
> +SELECT to_timestamp('2011-12-18 11:38 ...', 'YYYY-MM-DD HH12:MI TZ');  -- error
> +ERROR:  invalid value ".." for "TZ"

> Shouldn't the second error display the full value "..." (three dots)
> similarly to the previous one?

That's coming from the pre-existing OF code, which is looking for
a integer of at most two digits.  I'm not especially inclined to
mess with that, and even if I were I'd think it should be a separate
patch.

> Also I think we need at least one
> negative test for OF.

OK.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Daniel Verite"
Date:
Subject: Re: Fixing backslash dot for COPY FROM...CSV
Next
From: "Tristan Partin"
Date:
Subject: Re: make dist using git archive