Shouldn't postgres_fdw report warning when it gives up getting result from foreign server? - Mailing list pgsql-hackers

From Fujii Masao
Subject Shouldn't postgres_fdw report warning when it gives up getting result from foreign server?
Date
Msg-id 15aa988c-722e-ad3e-c936-4420c5b2bfea@oss.nttdata.com
Whole thread Raw
Responses Re: Shouldn't postgres_fdw report warning when it gives up getting result from foreign server?
List pgsql-hackers
Hi,

postgres_fdw reports no log message when it sends "ABORT TRANSACTION" etc
and gives up getting a reply from a foreign server because of timeout or
connection trouble. This makes the troubleshooting a bit harder when
using postgres_fdw.

So how about making postgres_fdw report a warning in that case?
Specifically I'm thinking to change pgfdw_get_cleanup_result()
in postgres_fdw/connection.c so that it reports a warning in case of
a timeout or connection failure (error of PQconsumeInput()).

BTW, pgfdw_get_cleanup_result() does almost the same things as
what pgfdw_get_result() does. So it might be good idea to refactor
those function to reduce the code duplication.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: dfmgr additional ABI version fields
Next
From: gkokolatos@pm.me
Date:
Subject: Re: Teach pg_receivewal to use lz4 compression