Re: psql tab completion bug and possible fix - Mailing list pgsql-patches

From Tom Lane
Subject Re: psql tab completion bug and possible fix
Date
Msg-id 1596.1066250719@sss.pgh.pa.us
Whole thread Raw
In response to Re: psql tab completion bug and possible fix  (Ian Barwick <barwick@gmx.net>)
Responses Re: psql tab completion bug and possible fix
List pgsql-patches
Ian Barwick <barwick@gmx.net> writes:
> On Tuesday 14 October 2003 23:38, Tom Lane wrote:
>> Surely all those replacements of \\ with \\\\ are wrong.

> The slash in the slash command gets escaped too...:

Not the way I did it.  You were doing the escaping in the wrong place
IMHO --- the string passed to _complete_from_query() mustn't be escaped
already, because it is not only used to send a command to the backend,
but also to compare against the strings returned by the backend, which
won't be escaped.  So the escaping needs to be done internally to
_complete_from_query(), and that eliminates the side-effects elsewhere.

            regards, tom lane

pgsql-patches by date:

Previous
From: Ian Barwick
Date:
Subject: Re: psql tab completion bug and possible fix
Next
From: Ian Barwick
Date:
Subject: Re: psql tab completion bug and possible fix