Re: remove ATTRIBUTE_FIXED_PART_SIZE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove ATTRIBUTE_FIXED_PART_SIZE
Date
Msg-id 15865.1535127387@sss.pgh.pa.us
Whole thread Raw
In response to Re: remove ATTRIBUTE_FIXED_PART_SIZE  (Andres Freund <andres@anarazel.de>)
Responses Re: remove ATTRIBUTE_FIXED_PART_SIZE
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-08-24 11:47:43 -0400, Tom Lane wrote:
>> Um ... this would be enough to document that we don't think there's a
>> *read* hazard, but Andres was claiming that there's also a *write* hazard.

> Right. The relevant standardese, in C11 (C99 very similar), is:
> 6.2.6.1 General, 6):
> "When a value is stored in an object of structure or union type, including in a member
> object, the bytes of the object representation that correspond to any padding bytes take
> unspecified values."

> I don't have the references at hand, but I'm fairly sure that at least
> gcc and clang can be made to exploit that.

Thing is, if that's true, why have we not seen field reports of catalog
corruption problems?  Maybe we're just fortunate that we don't try to
update the last fixed field of any catalog that way?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
Next
From: Andres Freund
Date:
Subject: Re: remove ATTRIBUTE_FIXED_PART_SIZE