Re: ALTER TEXT SEARCH DICTIONARY tab completion - Mailing list pgsql-hackers

From Georgios Kokolatos
Subject Re: ALTER TEXT SEARCH DICTIONARY tab completion
Date
Msg-id 158333417874.14910.10335541676760733599.pgcf@coridan.postgresql.org
Whole thread Raw
In response to ALTER TEXT SEARCH DICTIONARY tab completion  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: ALTER TEXT SEARCH DICTIONARY tab completion  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

It looks good and does what it says on the tin.

One minor nitpick I feel I should add is that for completeness and
balance the equivalent `CREATE TEXT SEARCH DICTIONARY` should 
get the same treatment.

Maybe something along the lines of:
-       else if (Matches("CREATE", "TEXT", "SEARCH", "CONFIGURATION", MatchAny))
+       else if (Matches("CREATE", "TEXT", "SEARCH", "DICTIONARY|CONFIGURATION", MatchAny))

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Asynchronous Append on postgres_fdw nodes.
Next
From: Laurenz Albe
Date:
Subject: Re: Berserk Autovacuum (let's save next Mandrill)