Postgres Pro
Downloads
Home   >   mailing lists

Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery(). - Mailing list pgsql-hackers

From Tom Lane
Subject Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery().
Date
Msg-id 15770.1658416968@sss.pgh.pa.us
Whole thread Raw
In response to postgres_fdw: Fix bug in checking of return value of PQsendQuery().  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
Tree view 
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> I found that fetch_more_data_begin() in postgres_fdw reports an error when PQsendQuery() returns the value less than
0as follows though PQsendQuery() can return only 1 or 0. I think this is  a bug. Attached is the patch that fixes this
bug.This needs to be back-ported to v14 where async execution was supported in postgres_fdw. 

Yup, clearly a thinko.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Next
From: Martin Kalcher
Date:
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()