Re: CPU costs of random_zipfian in pgbench - Mailing list pgsql-hackers

From Georgios Kokolatos
Subject Re: CPU costs of random_zipfian in pgbench
Date
Msg-id 155246731010.16480.15850913449923768119.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: CPU costs of random_zipfian in pgbench  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: CPU costs of random_zipfian in pgbench
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

For whatever it is worth, the patch looks good to me.

A minor nitpick would be to use a verb in the part:

`cost when the parameter in (0, 1)`

maybe:

`cost when the parameter's value is in (0, 1)` or similar.

Apart from that, I would suggest it that the patch could be moved to
Waiting for Author state.

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Introduce timeout capability for ConditionVariableSleep
Next
From: Fabien COELHO
Date:
Subject: Re: Offline enabling/disabling of data checksums