Re: changes to support logging - Mailing list pgsql-hackers

From Tom Lane
Subject Re: changes to support logging
Date
Msg-id 15403.1060267500@sss.pgh.pa.us
Whole thread Raw
In response to changes to support logging  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: changes to support logging
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> I've noticed an inconsistency in calls to gettimeofday(): sometimes it 
> is passed a struct tz (which is ignored) as the second argument, and 
> sometimes NULL as the second argument. My understanding is that the 
> second argument is basically useless anyway - on my Linux box man 
> gettimeofday says this:

You are confusing the second argument with something else (a field in
the first argument struct).  However, if we're assuming that NULL works
in some places, we may as well use it everywhere that it makes sense.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: changes to support logging
Next
From: Tom Lane
Date:
Subject: Re: 7.4beta1 build problem on unixware