Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #16484: pg_regress fails with --outputdir parameter - Mailing list pgsql-bugs

From Daniel Gustafsson
Subject Re: BUG #16484: pg_regress fails with --outputdir parameter
Date
Msg-id 153B2C23-E972-4D2B-BBD3-EA77AEB79329@yesql.se
Whole thread Raw
In response to BUG #16484: pg_regress fails with --outputdir parameter  (PG Bug reporting form <noreply@postgresql.org>)
Responses Re: BUG #16484: pg_regress fails with --outputdir parameter  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
Tree view 
> On 8 Jun 2020, at 07:45, PG Bug reporting form <noreply@postgresql.org> wrote:

> Hello,
> pg_regress fails when i try to change the output directory with
> "--outputdir" parameter.
> This happens bacause pg_regress creates the output directory, but doesn't
> create sql and expected subdirectories.

Nice catch, testing the attached patch does indeed make pg_regress run without
errors if outputdir doesn't exist.

While looking at it though, I noticed that we nearby use stat() in a single
place while the rest use check_directory().  Is there a reason to not use
check_directory consistently as per the attached diff?

cheers ./daniel
Attachment

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #16485: array_recv causes binary COPY to not work between postgres instances with arrays of custom types
Next
From: Vianello Fabio
Date:
Subject: RE: BUG #16481: Stored Procedure Triggered by Logical Replication isUnable to use Notification Events