Shaik Mohammad Mujeeb <mujeeb.sk@zohocorp.com> writes:
> In my patch, I currently warn and remove invalid GUCs from the hashtable. However, as you rightly pointed out, some
ofthese could belong to valid but unregistered prefixes. In such cases, it might not be ideal to remove them outright.
Instead,it could be more helpful to simply warn the user - covering both potential typos and GUCs with valid yet
unregisteredprefixes.
I kind of doubt that warnings at startup are all that helpful.
People don't look at the postmaster log all that often, and
by the time they start wondering why something isn't acting
as they expect, the log file that had the info may have been
rotated out of existence.
I doubt even more that removing GUCs just because they are
not registered prefixes is sane.
Let me suggest a different way of thinking about this: what
say we extend the pg_file_settings view to mark custom GUCs
that don't correspond to any reserved extension prefix?
"Not a known extension" could be one of the "error" messages
that that view provides.
regards, tom lane
