Re: COPY Fillfactor patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: COPY Fillfactor patch
Date
Msg-id 15251.1113314185@sss.pgh.pa.us
Whole thread Raw
In response to COPY Fillfactor patch  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: COPY Fillfactor patch
List pgsql-patches
Simon Riggs <simon@2ndquadrant.com> writes:
> During recent tuning of the TPC-C workload, I produced the following
> patch to force COPY to leave some space in each data block when it loads
> data into heap relations.

This is an amazingly ugly way to do it.  Put the info into the Relation
structure instead of cluttering heap_insert's API.  (This would mean
that *every* heap_insert is affected, not only COPY, which is what you
want anyway I would think.)

In practice, a real fix for this would add a column to pg_class, in
which case you could get it from the Relation for free.

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: OS Locale UTF-8
Next
From: Neil Conway
Date:
Subject: Re: COPY Fillfactor patch