Re: pg_upgrade automatic testing - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_upgrade automatic testing
Date
Msg-id 15239.1315007352@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_upgrade automatic testing  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pg_upgrade automatic testing
Re: pg_upgrade automatic testing
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 09/02/2011 06:37 PM, Peter Eisentraut wrote:
>> It won't work, unless you have a solution for fixing the paths of the
>> shared library modules used by the regression tests.

> Well, we could drop those functions and not run tests that require them. 
> Or we could possibly install the libraries in $libdir and hack pg_proc 
> accordingly. We'd have to install them on both the source and 
> destination branches, of course.

The only one that's problematic is pg_regress.so; contrib modules are
already installed in $libdir.  I still think that installing
pg_regress.so in $libdir may be the most reasonable solution, assuming
that the delta involved isn't too great.  Yeah, we would have to
back-patch the changes into every release branch we want to test
upgrading from, but how risky is that really?  The *only* thing it
affects is the regression tests.

Maybe I should produce a draft patch for moving pg_regress.so that way,
and we could see how big a delta it really is.

> Maybe we need to develop a test db specifically for pg_upgrade anyway.

Possibly, but it'll always be more impoverished than the regular
regression test DBs IMO.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pg_upgrade automatic testing
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_upgrade automatic testing