Re: timed PgConnection::Connect - Mailing list pgsql-patches

From Tom Lane
Subject Re: timed PgConnection::Connect
Date
Msg-id 15216.1028728325@sss.pgh.pa.us
Whole thread Raw
In response to timed PgConnection::Connect  (Denis A Ustimenko <denis@oldham.ru>)
Responses Re: timed PgConnection::Connect  (Denis A Ustimenko <denis@oldham.ru>)
List pgsql-patches
Denis A Ustimenko <denis@oldham.ru> writes:
> I write this to put timeout parameter in PgConnection::Connect.

This patch seems really messy.  In the first place, the timeout isn't on
total connection delay, but on individual waits of which there will be
several.  I'd think that's not really what you want.  In the second
place, I'd expect a timeout to be specified as a new optional parameter
in connection strings, not as an ad-hoc additional parameter in the API.

            regards, tom lane

pgsql-patches by date:

Previous
From: Rod Taylor
Date:
Subject: Re: current_database()
Next
From: Tom Lane
Date:
Subject: Re: current_database()