Re: [WIP PATCH] Index scan offset optimisation using visibility map - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [WIP PATCH] Index scan offset optimisation using visibility map
Date
Msg-id 152085845014.1307.17921890299725656162.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: [WIP PATCH] Index scan offset optimisation using visibility map  (Michail Nikolaev <michail.nikolaev@gmail.com>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

I've tested this patch with different types of order by, including needing recheck, but everything seems to work as
expected.
There are some missing spaces before some comment lines and I'm a bit unsure on some lines of code duplicated between
nodeIndexonlyscan.cand nodeIndexscan.c
 
But besides this, I have no more notes on the code.
I think the patch is ready for committer.

Best regards, Andrey Borodin.

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Partition-wise aggregation/grouping
Next
From: amul sul
Date:
Subject: Re: [HACKERS] Restrict concurrent update/delete with UPDATE ofpartition key