Re: New developer papercut - Makefile references INSTALL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New developer papercut - Makefile references INSTALL
Date
Msg-id 1520713.1644450733@sss.pgh.pa.us
Whole thread Raw
In response to Re: New developer papercut - Makefile references INSTALL  (Andres Freund <andres@anarazel.de>)
Responses Re: New developer papercut - Makefile references INSTALL  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-02-09 22:32:59 +0100, Magnus Hagander wrote:
>> post-commit hooks don't run on the git server, they run locally on
>> your machine. There is a "post receive" hook that runs on the git
>> server, but we definitely don't want that one to fabricate new commits
>> I think.

> Why not? We probably wouldn't want to do synchronously as part of the receive
> hook, but if we have a policy that INSTALL is not to be updated by humans, but
> updated automatically whenever its sources are modified, I'd be OK with
> auto-committing that.

What happens when the INSTALL build fails (which is quite possible,
I believe, even if a plain html build works)?

I don't really want any post-commit or post-receive hooks doing
anything interesting to the tree.  I think the odds for trouble
are significantly greater than any value we'd get out of it.

I'm in favor of unifying README and README.git along the lines
we discussed above.  I think that going further than that
will be a lot of trouble for very little gain; in fact no gain,
because I do not buy any of the arguments that have been
made about why changing the INSTALL setup would be beneficial.
If we adjust the README contents to be less confusing about that,
we're done.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Next
From: Tom Lane
Date:
Subject: Re: catalog access with reset GUCs during parallel worker startup