Re: New gist vacuum. - Mailing list pgsql-hackers

From Michail Nikolaev
Subject Re: New gist vacuum.
Date
Msg-id 151956654251.6915.675951950408204404.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: New gist vacuum.  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: New gist vacuum.  (Michail Nikolaev <michail.nikolaev@gmail.com>)
Re: New gist vacuum.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hello.

I have added small change to patch to allow it be compiled using msvc (uint64_t -> uint64).
Everything seems to work, check-world is passing.

Actually patch fixes two issues:
1) Partial GIST indexes now have corrent tuples count estimation.
2) Now subsequent calls to VACUUM on GIST index (like "VACCUM table_name") do not change tuples count to estimated
numberof tuples in table (which is changed even without any updates in table due current implementation).
 

I think it is fine to commit.

Patch is also availble on github:
https://github.com/michail-nikolaev/postgres/commit/ff5171b586e4eb60ea5d15a18055d8ea4e44d244?ts=4

I'll attach patch file next message.

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: handling of heap rewrites in logical decoding
Next
From: Michail Nikolaev
Date:
Subject: Re: New gist vacuum.