Re: libpq Win32 Mutex performance patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: libpq Win32 Mutex performance patch
Date
Msg-id 15033.1207940408@sss.pgh.pa.us
Whole thread Raw
In response to libpq Win32 Mutex performance patch  (Andrew Chernow <ac@esilo.com>)
Responses Re: libpq Win32 Mutex performance patch  (Andrew Chernow <ac@esilo.com>)
Re: libpq Win32 Mutex performance patch  (Andrew Chernow <ac@esilo.com>)
List pgsql-patches
Andrew Chernow <ac@esilo.com> writes:
> The attached patch replaces the win32 mutex calls with critical section
> calls.  The change will not affect the behavior of the windows
> pthread_xxx functions.

Why have you defined the lock/unlock functions as willing to fall
through silently if handed a null pointer?  I think a crash in
such a case is what we *want*.  Silently not locking is surely
not very safe.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Merlin Moncure"
Date:
Subject: Re: libpq Win32 Mutex performance patch
Next
From: Andrew Chernow
Date:
Subject: Re: libpq Win32 Mutex performance patch