Re: "debug_invalidate_system_caches_always" is too long - Mailing list pgsql-hackers

From Tom Lane
Subject Re: "debug_invalidate_system_caches_always" is too long
Date
Msg-id 1492832.1625512421@sss.pgh.pa.us
Whole thread Raw
In response to Re: "debug_invalidate_system_caches_always" is too long  (Noah Misch <noah@leadboat.com>)
Responses Re: "debug_invalidate_system_caches_always" is too long  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> On Sun, Jul 04, 2021 at 04:27:13PM -0400, Tom Lane wrote:
>> However, I think we should also give serious consideration to
>> "debug_clobber_cache" or "debug_clobber_cache_always" for continuity
>> with past practice (though it still feels like "always" is a good
>> word to lose now).  "debug_clobber_caches" is another reasonable
>> variant.

> https://en.wikipedia.org/wiki/Clobbering refers to cases where storage had no
> changes to its accessibility but now contains different data.  That doesn't
> match InvalidateSystemCaches() especially well, so I think dropping that word
> has been a good step.  Some other shorter terms could be debug_flush_caches,
> debug_rebuild_caches, or debug_expire_caches.  (debug_caches is tempting, but
> that may ensnare folks looking for extra logging rather than a big slowdown.)

I like "debug_flush_caches" --- it's short and accurate.

            regards, tom lane



pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates
Next
From: James Coleman
Date:
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates