Re: [HACKERS] Keep ECPG comment for log_min_duration_statement - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: [HACKERS] Keep ECPG comment for log_min_duration_statement
Date
Msg-id 1488195400.16046.34.camel@postgresql.org
Whole thread Raw
In response to Re: [HACKERS] Keep ECPG comment for log_min_duration_statement  ("Okano, Naoki" <okano.naoki@jp.fujitsu.com>)
Responses Re: [HACKERS] Keep ECPG comment for log_min_duration_statement  ("Okano, Naoki" <okano.naoki@jp.fujitsu.com>)
List pgsql-hackers
> Michael Meskes wrote:
> > The other option I can see, albeit without looking into details, is
> > allowing all comments and then testing it for the right syntax
> > after
> > parsing. This could potentially also solve the above mentioned
> > option
> > problem.
> 
> This idea sounds great. But I am not sure that I can understand it
> correctly.
> 
> I understood the concept of this idea as following. Is it right?
> 1. The parser ignores comments/*...*/ as usual. That is, parser does
> not 
>    identify comments as a token. 

I guess it'd be easier to accept each comment as a token and then parse
the token  text afterwards.

> 2. After parsing, we parse again only to extract comments.

Not sure if we can do that without creating a lot of overhead.

Michael

-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL



pgsql-hackers by date:

Previous
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Subject: Re: [HACKERS] [PATCH] Add tab completion for DEALLOCATE
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Documentation improvements for partitioning