Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Use quicksort, not replacement selection, for external sorting. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Use quicksort, not replacement selection, for external sorting.
Date
Msg-id 14682.1460126444@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Use quicksort, not replacement selection, for external sorting.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Use quicksort, not replacement selection, for external sorting.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view 
Robert Haas <rhaas@postgresql.org> writes:
> Use quicksort, not replacement selection, for external sorting.

This patch evidently broke several of the Windows buildfarm critters,
eg on mastodon:

Build FAILED.
.\src\backend\utils\sort\tuplesort.c(2373): error C2143: syntax error : missing ';' before 'type'
.\src\backend\utils\sort\tuplesort.c(2377): error C2065: 'ntuples' : undeclared identifier
    0 Warning(s)
    2 Error(s)



            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Phrase full text search.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Use quicksort, not replacement selection, for external sorting.