Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Date
Msg-id 1467434.1656914113@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Change timeline field of IDENTIFY_SYSTEM to int8  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
List pgsql-committers
Peter Eisentraut <peter@eisentraut.org> writes:
> Change timeline field of IDENTIFY_SYSTEM to int8

Surely this patch is far from complete?

To start with, just a few lines down in IdentifySystem() the column
is filled using Int32GetDatum not Int64GetDatum.  I will get some
popcorn and await the opinions of the 32-bit buildfarm animals.

But what about whatever code is reading the output?  And what if
that code isn't v16?  I can't believe that we can make a wire
protocol change as summarily as this.

            regards, tom lane



pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8