Re: Fix for erroneous warning on Shutdown - Mailing list pgsql-patches

From Tom Lane
Subject Re: Fix for erroneous warning on Shutdown
Date
Msg-id 14610.1087347717@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix for erroneous warning on Shutdown  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Fix for erroneous warning on Shutdown
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I just did CHECKPOINT;CHECKPOINT and got the warning in the logs.  This
> needs to be fixed.

See code:

            /*
             * Ideally we should only warn if this checkpoint was
             * requested due to running out of segment files, and not
             * if it was manually requested.  However we can't tell the
             * difference with the current signalling mechanism.
             */

I could argue that a client-driven process that issues CHECKPOINT every
few seconds is equally deserving of a warning.  The only thing wrong is
that the HINT is inapplicable ... but that's why it's a HINT and not
part of the main message.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Fix for erroneous warning on Shutdown
Next
From: Bruce Momjian
Date:
Subject: Re: Fix for erroneous warning on Shutdown