Re: Let's drop two obsolete features which are bear-traps for novices - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Let's drop two obsolete features which are bear-traps for novices
Date
Msg-id 1446.1414950119@sss.pgh.pa.us
Whole thread Raw
In response to Re: Let's drop two obsolete features which are bear-traps for novices  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Let's drop two obsolete features which are bear-traps for novices  (Michael Banck <michael.banck@credativ.de>)
Re: Let's drop two obsolete features which are bear-traps for novices  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
I wrote:
> Either way, requiring a dump/reload for upgrade is surely a better answer
> for users of the type than just summarily screwing them.

BTW, after reflecting a bit more I'm less than convinced that this
datatype is completely useless.  Even if you prefer to store currency
values in numeric columns, casting to or from money provides a way to
accept or emit values in whatever monetary format the LC_MONETARY locale
setting specifies.  That seems like a useful feature, and it's one you
could not easily duplicate using to_char/to_number (not to mention that
those functions aren't without major shortcomings of their own).

A quick trawl through the git history for cash.c indicates that most of
the bug fixes it's gotten recently have concerned doing formatting
correctly for non-US-like LC_MONETARY settings, so I think there are
indeed people out there who care about that capability.

Certainly we could package that capability in another way besides a
datatype, but I think we should actually do so (and give users a release
or two to switch over) before we consider nuking the type.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Let's drop two obsolete features which are bear-traps for novices
Next
From: Petr Jelinek
Date:
Subject: Re: tracking commit timestamps