Re: pgsql: Message improvements - Mailing list pgsql-committers

From David G Johnston
Subject Re: pgsql: Message improvements
Date
Msg-id 1415759208069-5826612.post@n5.nabble.com
Whole thread Raw
In response to pgsql: Message improvements  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
A couple of minor observations:

The new wording for this one seems worse off:

> incomplete read from reorderbuffer spill file: read %d instead of %u bytes

The "incomplete" aspect seems to be material...the proposed wording leads
one to believe the file is unreadable for some reason and then goes on to
say that bytes were read.

how about:

incomplete read of reorderbuffer spill file: read %d of expected %u bytes


> Writes full pages to WAL when first modified after a checkpoint, even for
> a non-critical modifications.

"... even for non-critical modifications." -- drop the "a" since
modifications is plural (or make it singular)

David J.





--
View this message in context: http://postgresql.nabble.com/pgsql-Message-improvements-tp5826611p5826612.html
Sent from the PostgreSQL - committers mailing list archive at Nabble.com.


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Message improvements
Next
From: Noah Misch
Date:
Subject: pgsql: Use just one database connection in the "tablespace" test.