Re: extension_control_path and "directory" - Mailing list pgsql-hackers

On 29.04.25 17:06, Matheus Alcantara wrote:
> On Tue, Apr 29, 2025 at 11:08 AM David E. Wheeler <david@justatheory.com> wrote:
>> Right. My point is a minor one, but I thin you can use an if/ else there:
>>
>> ```c
>> if (strcmp(piece, "$system") == 0) {
>>          /* Substitute the path macro if needed */
>>          mangled = substitute_path_macro(piece, "$system", system_dir);
>> } else {
>>          /*
>>          * Append "extension" suffix in case is a custom extension
>>          * control path.
>>          */
>>          mangled = psprintf("%s/extension", mangled);
>> }
>> ```
>>
> 
> The substitute_path_macro() already handles the if/else on "piece" but I
> think that this if/else version looks nicer. Fixed.
> 
> I've also included some documentation changes for this v5 version to
> remove the "extension" from the examples and also mention the scenario
> when using the "directory" on the .control file.

Thanks, I have committed this.  I did a bit of code reformatting and 
adjusted the documentation a bit.  It's good to get this in before beta1 
so that we don't have to change the valid values of 
extension_control_path past beta1.