Postgres Pro
Downloads
Home   >   mailing lists

pass Form_pg_attribute to examine_attribute rather than Relation structure. - Mailing list pgsql-hackers

From amul sul
Subject pass Form_pg_attribute to examine_attribute rather than Relation structure.
Date
Msg-id 1401878219.59710.YahooMailNeo@web193501.mail.sg3.yahoo.com
Whole thread Raw
Responses Re: pass Form_pg_attribute to examine_attribute rather than Relation structure.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
Hi,

examine_attribute() function accept Relation type argument, and extract attribute from it.

For more granularity, I think passing Form_pg_attribute to examine_attribute() function  rather than passing Relation will be more relevant & makes it simple to understand.

Thinking to change examine_attribute as,

- examine_attribute(Relation onerel, int attnum, Node *index_expr)
+examine_attribute(Form_pg_attribute attr, Node *index_expr)
 

I think there wont any loss or gain except little optimization of function call stack space. 

Thoughts? comments?

Please have look attached patch.

Regards,

Amul Sul
Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Allowing join removals for more join types
Next
From: Abhijit Menon-Sen
Date:
Subject: pg_xlogdump --stats