Re: pgsql/src backend/access/transam/xact.c backen ... - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src backend/access/transam/xact.c backen ...
Date
Msg-id 13996.1001739713@sss.pgh.pa.us
Whole thread Raw
In response to pgsql/src backend/access/transam/xact.c backen ...  (thomas@postgresql.org)
List pgsql-committers
I'm seeing the following failure in the rules regress test:

$ diff expected/rules.out results
1338c1338
<  shoelace_data | log_shoelace    | CREATE RULE log_shoelace AS ON UPDATE TO shoelace_data WHERE (new.sl_avail <>
old.sl_avail)DO INSERT INTO shoelace_log (sl_name, sl_avail, log_who, log_when) VALUES (new.sl_name, new.sl_avail, 'Al
Bundy'::name,'Thu Jan 01 00:00:00 1970'::"timestamp"); 
---
>  shoelace_data | log_shoelace    | CREATE RULE log_shoelace AS ON UPDATE TO shoelace_data WHERE (new.sl_avail <>
old.sl_avail)DO INSERT INTO shoelace_log (sl_name, sl_avail, log_who, log_when) VALUES (new.sl_name, new.sl_avail, 'Al
Bundy'::name,"timestamp"('epoch'::text)); 
$

The actual result corresponds to the former output, and is indeed what
I would expect, given that text_timestamp() is (and should be)
non-cachable.  Are you sure this expected file is correct?

I'm also seeing rather massive failures in horology, but this evidently
is because horology-no-DST-before-1970.out hasn't been updated ...

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org
Date:
Subject: pgsql/ oc/src/sgml/wal.sgml rc/backend/access/ ...
Next
From: tgl@postgresql.org
Date:
Subject: pgsql/src/test/regress/expected horology-no-DS ...