Re: message string fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: message string fixes
Date
Msg-id 13811.1200866094@sss.pgh.pa.us
Whole thread Raw
In response to Re: message string fixes  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: message string fixes  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Teodor Sigaev <teodor@sigaev.ru> writes:
> There is a  fallback to regex if expression isn't supported by regis (see call 
> of RS_isRegis() in spell.c).

Oh.  So in that case, the messages Alvaro is worried about
               ereport(ERROR,                       (errcode(ERRCODE_INVALID_REGULAR_EXPRESSION),
errmsg("invalid regis pattern: \"%s\"",                               str)));
 

aren't user-facing errors at all, and should be demoted to elog's,
correct?
               elog(ERROR, "invalid regis pattern: \"%s\"", str);

        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Minor bug in src/port/rint.c
Next
From: Magnus Hagander
Date:
Subject: Re: Minor bug in src/port/rint.c