Re: PRI?64 vs Visual Studio (2022) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PRI?64 vs Visual Studio (2022)
Date
Msg-id 1377512.1763522154@sss.pgh.pa.us
Whole thread Raw
In response to Re: PRI?64 vs Visual Studio (2022)  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> Perhaps meson/configure should do a po -> mo -> gettext() check with a
> canned test message?  That'd also make sure your msgfmt and libintl
> are compatible, something I worried about when I wrote about musl
> recently.

No, I don't think that's a good approach.  That is testing the library
available at configure time, not the one you are actually running
with (possibly years later and on a different machine, even without
considering cross-compilation cases).  I think we should do it
honestly with a regression test.  It doesn't need to be very
complicated --- I think checking one message in one translation is
sufficient, so long as it includes a PRI?64 usage.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Optimize LISTEN/NOTIFY
Next
From: "cca5507"
Date:
Subject: Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS?