Re: PRI?64 vs Visual Studio (2022) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: PRI?64 vs Visual Studio (2022)
Date
Msg-id e7b902aa-98ac-4d35-bae3-d7d282a938c2@eisentraut.org
Whole thread Raw
In response to Re: PRI?64 vs Visual Studio (2022)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 19.11.25 04:15, Tom Lane wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> Perhaps meson/configure should do a po -> mo -> gettext() check with a
>> canned test message?  That'd also make sure your msgfmt and libintl
>> are compatible, something I worried about when I wrote about musl
>> recently.
> 
> No, I don't think that's a good approach.  That is testing the library
> available at configure time, not the one you are actually running
> with (possibly years later and on a different machine, even without
> considering cross-compilation cases).  I think we should do it
> honestly with a regression test.  It doesn't need to be very
> complicated --- I think checking one message in one translation is
> sufficient, so long as it includes a PRI?64 usage.

We could generate an English message catalog that translates all 
messages unchanged, and run the whole test suite with that.  This would 
exercise the whole gettext run-time machinery.

Generating the message catalog is easy, gettext provides a tool for 
that.  What's a little tricky is convincing all our testing 
infrastructure to *not* disable NLS-related locale settings.  See 
attached for a rough, incomplete demo.

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: gen_guc_tables.pl: Validate required GUC fields before code generation
Next
From: Chao Li
Date:
Subject: Re: gen_guc_tables.pl: Validate required GUC fields before code generation