Re: v7.4.1 text_position() patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: v7.4.1 text_position() patch
Date
Msg-id 13708.1075476712@sss.pgh.pa.us
Whole thread Raw
In response to v7.4.1 text_position() patch  ("Korea PostgreSQL Users' Group" <pgsql-kr@postgresql.or.kr>)
List pgsql-patches
"Korea PostgreSQL Users' Group" <pgsql-kr@postgresql.or.kr> writes:
> In src/backend/utils/adt/varlena.c,
> 766 line must be exits in block of 'else if (elm >1)' too.
> Because, strpos() function make a wrong result in multibyte string.

Hm.  I don't think it can actually fail, because the wchar strings are
zero-terminated.  But it does look like there's a missed speedup here.
(Tatsuo, do you agree?)

Thanks for the report!

            regards, tom lane

pgsql-patches by date:

Previous
From: "Korea PostgreSQL Users' Group"
Date:
Subject: v7.4.1 text_position() patch
Next
From: "Korea PostgreSQL Users' Group"
Date:
Subject: Re: v7.4.1 text_position() patch