Re: visibilitymap_set and checksums - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: visibilitymap_set and checksums
Date
Msg-id 1369846404.9884.0.camel@jdavis-laptop
Whole thread Raw
In response to Re: visibilitymap_set and checksums  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On Fri, 2013-05-24 at 22:16 +0100, Simon Riggs wrote: 
> I think its perfectly understandable. Robert, Jeff and I discussed
> that for a while before we passed it. I'm still not happy with it, and
> think its a pretty confusing section of code with multiple paths
> through it, but I just can't see a better way.

Agreed on all counts. Comment patches are welcome, of course.

I'll add that if we remove PD_ALL_VISIBLE, this complexity disappears.

Regards,Jeff Davis






pgsql-hackers by date:

Previous
From: Abhishek Rai
Date:
Subject: Re: pg_stat_replication when standby is unreachable
Next
From: Jeff Davis
Date:
Subject: Re: getting rid of freezing