Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.
Date
Msg-id 13617.1277392523@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.  (Florian Pflug <fgp@phlo.org>)
Responses Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Florian Pflug <fgp@phlo.org> writes:
> On Jun 24, 2010, at 16:45 , Robert Haas wrote:
>> I think the existing names are fine - people should understand that
>> "options" means "server-side options" and that anything else is a
>> client-side option.  However, if there's a strong consensus the other
>> way and someone feels like working up a patch, that's fine too.

> I'd volunteer to create the patch if people think renaming the libpq options is a good idea.

I'm with Robert: the names are fine as-is.  We've not had complaints
about the libpq SSL parameters being confusingly like server-side SSL
parameters, for instance.

It might be a good idea to add a sentence to the documentation, though,
just pointing out that these control client-side keepalive probes rather
than server-side.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.
Next
From: Carsten Kropf
Date:
Subject: Re: TOAST issue on custom index access method