Re: src/ports/pgcheckdir.c - Ignore dot directories... - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: src/ports/pgcheckdir.c - Ignore dot directories...
Date
Msg-id 1360067577.87648.YahooMailNeo@web162903.mail.bf1.yahoo.com
Whole thread Raw
In response to src/ports/pgcheckdir.c - Ignore dot directories...  (Sean Chittenden <sean@chittenden.org>)
Responses Re: src/ports/pgcheckdir.c - Ignore dot directories...
Re: src/ports/pgcheckdir.c - Ignore dot directories...
Re: src/ports/pgcheckdir.c - Ignore dot directories...
Re: src/ports/pgcheckdir.c - Ignore dot directories...
List pgsql-hackers
Sean Chittenden <sean@chittenden.org> wrote:

> Currently src/port/pgcheckdir.c will reject non-empty
> directories, which is an issue during initdb(1) when PGDATA is
> also the mount point for filesystems that support snapshots (e.g.
> ZFS or UFS2).

> Granted it's not hard to create a subdirectory, initdb there and
> move the contents of the files around, it's extra work that
> shouldn't be required.

I feel that it is very bad practice to use the mount point as the
PGDATA directory.  It forcloses a lot of reasonable actions that
someone managing the database server might want to take.

It's hard to get enthusiastic about a patch to make bad practice
more convenient.  I would rather add a sentence or two to the
initdb documentation recommending that a cluster not be created at
a mount point; it should be created in a directory underneath the
mount point.

-Kevin




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: sql_drop Event Trigger
Next
From: Sean Chittenden
Date:
Subject: Re: src/ports/pgcheckdir.c - Ignore dot directories...