Re: Rejection of the smallest int8 - Mailing list pgsql-patches

From Tom Lane
Subject Re: Rejection of the smallest int8
Date
Msg-id 13599.1006355169@sss.pgh.pa.us
Whole thread Raw
In response to Rejection of the smallest int8  (sugita@sra.co.jp)
Responses Re: Rejection of the smallest int8  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Rejection of the smallest int8  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Rejection of the smallest int8  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
sugita@sra.co.jp writes:
> Attached is a patch to accept the smallest value of int8.

This has been proposed before.  The problem with it is that it's
not portable: the C standard does not specify the direction of rounding
of integer division when the dividend is negative.  So the test
inside the loop that tries to detect overflow would be likely to fail
on some machines.

If you can see a way around that, we're all ears ...

            regards, tom lane

pgsql-patches by date:

Previous
From: sugita@sra.co.jp
Date:
Subject: Rejection of the smallest int8
Next
From: Tom Lane
Date:
Subject: Re: Rejection of the smallest int8