Re: pg_regress/pg_isolation_regress: Fix possible nullptr dereference. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_regress/pg_isolation_regress: Fix possible nullptr dereference.
Date
Msg-id 1357296.1669827588@sss.pgh.pa.us
Whole thread Raw
In response to pg_regress/pg_isolation_regress: Fix possible nullptr dereference.  (Xing Guo <higuoxing@gmail.com>)
List pgsql-hackers
Xing Guo <higuoxing@gmail.com> writes:
> While playing with pg_regress and pg_isolation_regress, I noticed that
> there's a potential nullptr deference in both of them.
> How to reproduce:
> Specify the `--dbname=` option without providing any database name.

Hmm, yeah, I see that too.

> Patch is attached.

This patch seems like a band-aid, though.  The reason nobody's
noticed this for decades is that it doesn't make a lot of sense
to allow tests to run in your default database: the odds of them
screwing up something valuable are high, and the odds that they'll
fail if started in a nonempty database are even higher.

I think the right answer is to treat it as an error if we end up
with an empty dblist (or even a zero-length name).

            regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Add 64-bit XIDs into PostgreSQL 15
Next
From: gkokolatos@pm.me
Date:
Subject: Re: Add LZ4 compression in pg_dump