Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates
Date
Msg-id 13551.1366911752@sss.pgh.pa.us
Whole thread Raw
In response to Bug Fix: COLLATE with multiple ORDER BYs in aggregates  (David Fetter <david@fetter.org>)
Responses Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates
List pgsql-hackers
David Fetter <david@fetter.org> writes:
> While testing the upcoming FILTER clause for aggregates, Erik Rijkers
> uncovered a long-standing bug in $subject, namely that this case
> wasn't handled.  Please find attached a patch by Andrew Gierth and
> myself which fixes this issue and adds a regression test to ensure it
> remains fixed.

I don't find this patch to be a good idea.

The argument for it seems to be that

array_agg(a COLLATE "C" ORDER BY b COLLATE "POSIX")

should not throw an error, but why not?  And what does that have to do
with whacking around the code for CASE?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [ADMIN] Simultaneous index creates on different schemas cause deadlock?
Next
From: Andres Freund
Date:
Subject: Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates