[PATCH 04/14] Add a new RELFILENODE syscache to fetch a pg_class entry via (reltablespace, relfilenode) - Mailing list pgsql-hackers

From Andres Freund
Subject [PATCH 04/14] Add a new RELFILENODE syscache to fetch a pg_class entry via (reltablespace, relfilenode)
Date
Msg-id 1352942234-3953-4-git-send-email-andres@2ndquadrant.com
Whole thread Raw
In response to logical changeset generation v3  (andres@anarazel.de (Andres Freund))
List pgsql-hackers
This cache is somewhat problematic because formally indexes used by syscaches
needs to be unique, this one is not. This is "just" because of 0/InvalidOids
stored in pg_class.relfilenode for nailed/shared catalog relations.  The
syscache will never be queried for InvalidOid relfilenodes however so it seems
to be safe even if it violates the rules somewhat.

It might be nicer to add infrastructure to do this properly, like using a
partial index, its not clear what the best way to do this is though.

Needs a CATVERSION bump.
---
 src/backend/utils/cache/syscache.c | 11 +++++++++++
 src/include/catalog/indexing.h     |  2 ++
 src/include/catalog/pg_proc.h      |  1 +
 src/include/utils/syscache.h       |  1 +
 4 files changed, 15 insertions(+)


Attachment

pgsql-hackers by date:

Previous
From: andres@anarazel.de (Andres Freund)
Date:
Subject: logical changeset generation v3
Next
From: Andres Freund
Date:
Subject: [PATCH 05/14] Add a new relmapper.c function RelationMapFilenodeToOid that acts as a reverse of RelationMapOidToFilenode