Request a Demo
Home   >   mailing lists

Re: [PATCH] pgindent truncates last line of files missing a trailing newline - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] pgindent truncates last line of files missing a trailing newline
Date
Msg-id 1352724.1774639696@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] pgindent truncates last line of files missing a trailing newline  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCH] pgindent truncates last line of files missing a trailing newline
List pgsql-hackers
Tree view 
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2026-03-26 Th 12:29 PM, Tom Lane wrote:
>> I'm not sure I want to expend the brain cells to figure out whether
>> this is a correct/complete patch.  If pg_bsd_indent were less of an
>> undercommented spaghetti-code nightmare, maybe fixing it here would
>> be reasonable.  But as things stand, why don't we just fix this in
>> the perl wrapper, as attached?

> Well, I thought we were trying to reduce the fixups we did in pgindent. 

Yeah, other things being equal I too would prefer to fix it within
pg_bsd_indent.  But other things are not equal: the complexity
and reviewability of the proposed v2 patch are not comparable to
a one-liner fix in the wrapper.

> However, I take your point about the ugly nature of the pg_bsd_indent 
> code. So I'm ok with this fix, which is quite straightforward.

I'll make it so.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Next
From: Melanie Plageman
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)